Skip to content

Conversation

justin-tahara
Copy link
Contributor

Description

We should have bumped the helm version when making the changes below and retroactively making the helm update now.

PR with helm update: #4893
[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]
Version bump which should have been tied to the above PR.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Summary by cubic

Bumped the Helm chart version to 0.2.3 to reflect recent Vespa resource configuration changes. Reduced Vespa node count and increased memory allocation per node.

@justin-tahara justin-tahara requested review from Weves and evan-onyx July 29, 2025 20:37
@justin-tahara justin-tahara requested a review from a team as a code owner July 29, 2025 20:37
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 8:39pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR performs a simple Helm chart version increment from 0.2.2 to 0.2.3 in the deployment/helm/charts/onyx/Chart.yaml file. This is a retroactive version bump that should have been included with PR #4893, which made infrastructure changes to Vespa resource configuration (reducing node count and increasing memory allocation per node).

The change follows proper Helm versioning practices where any modifications to chart configuration should trigger a version increment. This ensures proper tracking and deployment management, allowing users and deployment systems to understand that changes have been made since the previous version. The Chart.yaml file maintains all its existing metadata, dependencies, and configuration - only the version field on line 8 has been updated.

This type of version management is critical in Helm chart distribution as it enables proper rollback capabilities and ensures deployment consistency across environments. The change integrates seamlessly with the existing chart structure and maintains backward compatibility.

Confidence score: 5/5

  • This PR is extremely safe to merge with virtually no risk of production issues
  • The change is a simple semantic version increment with no functional modifications to dependencies, metadata, or chart logic
  • No files require additional attention as this is a straightforward version bump

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@justin-tahara justin-tahara merged commit 56f16d1 into main Jul 29, 2025
15 of 17 checks passed
@justin-tahara justin-tahara deleted the jtahara/helm-version-increment branch July 29, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants